improve hash distribution with short strings #109
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strings shorter than 128 bytes collide possible due to the implementation details of
MurmurHash3_x64_128()
. Especially, the hash value seems to depend on the length of such a string.For such a short string, we concatenate it as many times as needed to make it longer than 128 bytes.
Added a test to show hash results.
For example, before this fix,
test_murmur3 3 1024 data1.txt data2.txt data3.txt 123456.txt 1data5.txt data91.txt
showed the following resultsAfter the fix, the below is the new results.